Skip to content

docs(core/dtos): improve by adding other usages #2167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: 4.0
Choose a base branch
from
Open

docs(core/dtos): improve by adding other usages #2167

wants to merge 1 commit into from

Conversation

vinceAmstoutz
Copy link
Member

@vinceAmstoutz vinceAmstoutz commented Jun 8, 2025 •
edited
Loading

Completes #2076.

Also fixes a coding style issue introduced by this commit e751b7e.

@vinceAmstoutz vinceAmstoutz self-assigned this Jun 8, 2025
@vinceAmstoutz vinceAmstoutz force-pushed the docs/core/improve-dto-doc-by-adding-other-usages branch from e38ef0f to ecf50e4 Compare June 8, 2025 11:58
@vinceAmstoutz vinceAmstoutz marked this pull request as ready for review June 8, 2025 11:58
@vinceAmstoutz vinceAmstoutz force-pushed the docs/core/improve-dto-doc-by-adding-other-usages branch 2 times, most recently from 4599bba to 9b8f409 Compare June 8, 2025 12:17
soyuka
soyuka reviewed Jun 10, 2025
View reviewed changes
vinceAmstoutz
vinceAmstoutz commented Jun 10, 2025
View reviewed changes
@vinceAmstoutz vinceAmstoutz requested a review from soyuka June 10, 2025 15:11
@vinceAmstoutz vinceAmstoutz force-pushed the docs/core/improve-dto-doc-by-adding-other-usages branch from 47e8434 to b487437 Compare June 12, 2025 07:46
soyuka
soyuka requested changes Jun 13, 2025
View reviewed changes
@vinceAmstoutz vinceAmstoutz force-pushed the docs/core/improve-dto-doc-by-adding-other-usages branch from b487437 to 9d49823 Compare June 13, 2025 12:26
@vinceAmstoutz
docs(core/dtos): improve by adding other usages
0bd7016 
fix(dto): remove useless doc

fix(operation): remove unused operation

fix(typing): wrong return type

fix(lint/md): bare url
@vinceAmstoutz vinceAmstoutz force-pushed the docs/core/improve-dto-doc-by-adding-other-usages branch from 9d49823 to 0bd7016 Compare June 13, 2025 12:28
@vinceAmstoutz vinceAmstoutz requested a review from soyuka June 13, 2025 12:28
@alexandre-daubois
Copy link

alexandre-daubois commented Aug 7, 2025 •
edited
Loading

I struggled to find "simple ways" to deal with DTOs in APIP a few months back, so any additional info about it is really welcomed. Last time I checked, I wanted to created routes with basic filtering/sorting combined with DTO and I was surprised Doctrine Collection Provider wasn't mentioned as well. Maybe something to add?
Thanks!

@vinceAmstoutz
Copy link
Member Author

vinceAmstoutz commented Aug 7, 2025 •
edited
Loading

I struggled to find "simple ways" to deal with DTOs in APIP a few months back, so any additional info about it is really welcomed. Last time I checked, I wanted to created routes with basic filtering/sorting combined with DTO and I was surprised Doctrine Collection Provider wasn't mentioned as well. Maybe something to add? Thanks!

That's what I've tried to explain @soyuka and why I started with that #2167 (comment) (which now removed to fit with your review).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dunglas dunglas Awaiting requested review from dunglas

@alanpoulain alanpoulain Awaiting requested review from alanpoulain

@soyuka soyuka Awaiting requested review from soyuka

Assignees

@vinceAmstoutz vinceAmstoutz

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vinceAmstoutz @alexandre-daubois @soyuka